Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create KeyVal Annotation constructor #104

Merged
merged 1 commit into from
Dec 23, 2018

Conversation

gleachkr
Copy link
Contributor

@gleachkr gleachkr commented Nov 21, 2018

This pull request creates an Key Value annotation constructor along the lines of the discussion at

https://groups.google.com/forum/#!topic/diagrams-discuss/VOTjjDGQ-tg

It's intended to make it easier to set, for example, id and class in svg diagrams. The type of the key and value might not be what you had in mind. If there's a more type-safe approach you would prefer, just let me know.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@cchalmers
Copy link
Member

Looks good. Sorry it took so long, I must have missed it when you made the pr.

@cchalmers cchalmers merged commit ad76e96 into diagrams:master Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants